On 02/12/2022 04:37, Bjorn Andersson wrote: > On Fri, Nov 18, 2022 at 11:22:41AM -0800, Melody Olvera wrote: >> Add DTs for Qualcomm IDP platforms using the QDU1000 and QRU1000 >> SoCs. >> >> Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> >> --- (...) >> + vph_pwr: vph-pwr-regulator { >> + compatible = "regulator-fixed"; >> + regulator-name = "vph_pwr"; >> + regulator-min-microvolt = <3700000>; >> + regulator-max-microvolt = <3700000>; >> + >> + regulator-always-on; >> + regulator-boot-on; >> + >> + vin-supply = <&ppvar_sys>; >> + }; >> +}; >> + >> +&apps_rsc { >> + regulators { > > Seems like this is supposed to match -regulators$, so how about > pm8150-regulators? No, it's correct as model numbers should not be used for node names. https://lore.kernel.org/linux-devicetree/20220926092104.111449-1-krzysztof.kozlowski@xxxxxxxxxx/ https://lore.kernel.org/all/d13d5638-67b1-218b-c16d-505a389ccc42@xxxxxxxxxxx/ Best regards, Krzysztof