Hi Asutosh, On Tue, 2022-11-29 at 10:53 -0800, Asutosh Das wrote: > Define the mcq resources and add support to ioremap > the resource regions. > > Co-developed-by: Can Guo <quic_cang@xxxxxxxxxxx> > Signed-off-by: Can Guo <quic_cang@xxxxxxxxxxx> > Signed-off-by: Asutosh Das <quic_asutoshd@xxxxxxxxxxx> > Reviewed-by: Manivannan Sadhasivam <mani@xxxxxxxxxx> > --- > drivers/ufs/core/ufs-mcq.c | 3 ++ > drivers/ufs/core/ufshcd-priv.h | 8 ++++ > drivers/ufs/host/ufs-qcom.c | 103 > +++++++++++++++++++++++++++++++++++++++++ > include/ufs/ufshcd.h | 30 ++++++++++++ > 4 files changed, 144 insertions(+) > > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c > index bf08ec5..d6807e3 100644 > --- a/drivers/ufs/core/ufs-mcq.c > +++ b/drivers/ufs/core/ufs-mcq.c > @@ -119,7 +119,10 @@ int ufshcd_mcq_init(struct ufs_hba *hba) > int ret; > > ret = ufshcd_mcq_config_nr_queues(hba); > + if (ret) > + return ret; > > + ret = ufshcd_vops_mcq_config_resource(hba); > return ret; > } > > diff --git a/drivers/ufs/core/ufshcd-priv.h > b/drivers/ufs/core/ufshcd-priv.h > index 9368ba2..74cb17b9 100644 > --- a/drivers/ufs/core/ufshcd-priv.h > +++ b/drivers/ufs/core/ufshcd-priv.h > @@ -227,6 +227,14 @@ static inline void > ufshcd_vops_config_scaling_param(struct ufs_hba *hba, > hba->vops->config_scaling_param(hba, p, data); > } > > +static inline int ufshcd_vops_mcq_config_resource(struct ufs_hba > *hba) > +{ > + if (hba->vops && hba->vops->mcq_config_resource) > + hba->vops->mcq_config_resource(hba); > Please correct: return hba->vops->mcq_config_resource(hba); > + > + return -EOPNOTSUPP; > +} > + > Except this issue, I test this series pass on my platform. Thanks the patch Eddie