On Tue, Nov 29 2022 at 07:39 -0800, Manivannan Sadhasivam wrote:
Hi Asutosh,
On Mon, Nov 28, 2022 at 05:20:41PM -0800, Asutosh Das wrote:
UFS Multi-Circular Queue (MCQ) has been added in UFSHCI v4.0 to improve storage performance.
The implementation uses the shared tagging mechanism so that tags are shared
among the hardware queues. The number of hardware queues is configurable.
This series doesn't include the ESI implementation for completion handling.
This implementation has been verified by on a Qualcomm platform.
Please take a look and let us know your thoughts.
v5 -> v6:
- Addressed Mani's comments
- Addressed Bart's comments
Thanks for the continuous update of the series. In this version, you
seem to have missed some review tags from myself and Bart. Please
make sure to collect all tags in the next version if you happen to
send one.
Thanks Mani. I will send an updated series with the tags added today.
-asd
Thanks,
Mani
v4 -> v5:
- Fixed failure to fallback to SDB during initialization
- Fixed failure when rpm-lvl=5 in the ufshcd_host_reset_and_restore() path
- Improved ufshcd_mcq_config_nr_queues() to handle different configurations
- Addressed Bart's comments
- Verified read/write using FIO, clock gating, runtime-pm[lvl=3, lvl=5]
v3 -> v4:
- Added a kernel module parameter to disable MCQ mode
- Added Bart's reviewed-by tag for some patches
- Addressed Bart's comments
v2 -> v3:
- Split ufshcd_config_mcq() into ufshcd_alloc_mcq() and ufshcd_config_mcq()
- Use devm_kzalloc() in ufshcd_mcq_init()
- Free memory and resource allocation on error paths
- Corrected typos in code comments
v1 -> v2:
- Added a non MCQ related change to use a function to extrace ufs extended
feature
- Addressed Mani's comments
- Addressed Bart's comments
v1:
- Split the changes
- Addressed Bart's comments
- Addressed Bean's comments
* RFC versions:
v2 -> v3:
- Split the changes based on functionality
- Addressed queue configuration issues
- Faster SQE tail pointer increments
- Addressed comments from Bart and Manivannan
v1 -> v2:
- Enabled host_tagset
- Added queue num configuration support
- Added one more vops to allow vendor provide the wanted MAC
- Determine nutrs and can_queue by considering both MAC, bqueuedepth and EXT_IID support
- Postponed MCQ initialization and scsi_add_host() to async probe
- Used (EXT_IID, Task Tag) tuple to support up to 4096 tasks (theoretically)
Asutosh Das (16):
ufs: core: Optimize duplicate code to read extended feature
ufs: core: Probe for ext_iid support
ufs: core: Introduce Multi-circular queue capability
ufs: core: Defer adding host to scsi if mcq is supported
ufs: core: mcq: Add support to allocate multiple queues
ufs: core: mcq: Configure resource regions
ufs: core: mcq: Calculate queue depth
ufs: core: mcq: Allocate memory for mcq mode
ufs: core: mcq: Configure operation and runtime interface
ufs: core: mcq: Use shared tags for MCQ mode
ufs: core: Prepare ufshcd_send_command for mcq
ufs: core: mcq: Find hardware queue to queue request
ufs: core: Prepare for completion in mcq
ufs: mcq: Add completion support of a cqe
ufs: core: mcq: Add completion support in poll
ufs: core: mcq: Enable Multi Circular Queue
drivers/ufs/core/Makefile | 2 +-
drivers/ufs/core/ufs-mcq.c | 416 +++++++++++++++++++++++++++++++++++++++++
drivers/ufs/core/ufshcd-priv.h | 92 ++++++++-
drivers/ufs/core/ufshcd.c | 395 +++++++++++++++++++++++++++++++-------
drivers/ufs/host/ufs-qcom.c | 148 +++++++++++++++
drivers/ufs/host/ufs-qcom.h | 5 +
include/ufs/ufs.h | 6 +
include/ufs/ufshcd.h | 128 +++++++++++++
include/ufs/ufshci.h | 64 +++++++
9 files changed, 1189 insertions(+), 67 deletions(-)
create mode 100644 drivers/ufs/core/ufs-mcq.c
--
2.7.4
