Re: [PATCH 2/2] ARM: dts: qcom: msm8974: Add OnePlus One

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/11/2022 19:18, Luca Weiss wrote:
> From: Julian Goldsmith <julian@xxxxxxxxxxxxxxxxxxx>
> 
> OnePlus One is a smartphone launched in 2014 and is based on the
> Snapdragon 801 SoC (-AC variant).
> 

Thank you for your patch. There is something to discuss/improve.
> +
> +&blsp1_uart2 {
> +	status = "okay";
> +};
> +
> +&gcc {
> +	compatible = "qcom,gcc-msm8974pro-ac";
> +};
> +
> +&otg {
> +	phys = <&usb_hs1_phy>;
> +	phy-select = <&tcsr 0xb000 0>;
> +	extcon = <&smbb>, <&usb_id>;
> +	vbus-supply = <&chg_otg>;
> +
> +	hnp-disable;
> +	srp-disable;
> +	adp-disable;
> +
> +	status = "okay";
> +
> +	ulpi {
> +		phy@a {
> +			status = "okay";

Override by label (usb_hs1_phy). If the labels are named similarly, e.g.
usb_oth and usb_hs1_phy, then they will appear next to each other during
override/extend.

Best regards,
Krzysztof




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux