On 25.11.2022 15:42, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects certain pattern:
>
> qcom/msm8998-oneplus-cheeseburger.dtb: leds: 'button-backlight' does not match any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
> qcom/sc7180-trogdor-coachz-r1.dtb: pwmleds: 'keyboard-backlight' does not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
Konrad
> arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts | 2 +-
> arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> index b951f98d1b7b..9fb1fb9b8529 100644
> --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-cheeseburger.dts
> @@ -22,7 +22,7 @@ leds {
> pinctrl-names = "default";
> pinctrl-0 = <&button_backlight_default>;
>
> - button-backlight {
> + led-keypad-backlight {
> gpios = <&pmi8998_gpio 5 GPIO_ACTIVE_HIGH>;
> color = <LED_COLOR_ID_WHITE>;
> function = LED_FUNCTION_KBD_BACKLIGHT;
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 65601bea0797..74a90948db6b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -354,7 +354,7 @@ max98360a: audio-codec-0 {
>
> pwmleds {
> compatible = "pwm-leds";
> - keyboard_backlight: keyboard-backlight {
> + keyboard_backlight: led-0 {
> status = "disabled";
> label = "cros_ec::kbd_backlight";
> function = LED_FUNCTION_KBD_BACKLIGHT;
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 448da9794722..27f479ff9d80 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -307,7 +307,7 @@ max98360a: audio-codec-0 {
> pwmleds: pwmleds {
> compatible = "pwm-leds";
> status = "disabled";
> - keyboard_backlight: keyboard-backlight {
> + keyboard_backlight: led-0 {
> label = "cros_ec::kbd_backlight";
> function = LED_FUNCTION_KBD_BACKLIGHT;
> pwms = <&cros_ec_pwm 0>;
