On Sat, Nov 19, 2022 at 04:44:23PM +0000, Srinivas Kandagatla wrote: > Add GPR node along with APM(Audio Process Manager) and PRM(Proxy > resource Manager) audio services. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > --- > arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 40 ++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > index c32bcded2aef..a610c12103bf 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi > @@ -12,6 +12,7 @@ > #include <dt-bindings/power/qcom-rpmpd.h> > #include <dt-bindings/soc/qcom,rpmh-rsc.h> > #include <dt-bindings/thermal/thermal.h> > +#include <dt-bindings/soc/qcom,gpr.h> Again, please keep the includes sorted. > / { > interrupt-parent = <&intc>; > @@ -1152,9 +1153,48 @@ IPCC_MPROC_SIGNAL_GLINK_QMP > > label = "lpass"; > qcom,remote-pid = <2>; > + > + gpr { > + compatible = "qcom,gpr"; > + qcom,glink-channels = "adsp_apps"; > + qcom,domain = <GPR_DOMAIN_ID_ADSP>; > + qcom,intents = <512 20>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + q6apm: service@1 { > + compatible = "qcom,q6apm"; > + reg = <GPR_APM_MODULE_IID>; > + #sound-dai-cells = <0>; > + qcom,protection-domain = "avs/audio", > + "msm/adsp/audio_pd"; > + q6apmdai: dais { > + compatible = "qcom,q6apm-dais"; > + iommus = <&apps_smmu 0x0c01 0x0>; > + }; > + > + q6apmbedai: bedais { > + compatible = "qcom,q6apm-lpass-dais"; > + #sound-dai-cells = <1>; > + }; > + }; > + > + q6prm: service@2 { > + compatible = "qcom,q6prm"; > + reg = <GPR_PRM_MODULE_IID>; > + qcom,protection-domain = "avs/audio", > + "msm/adsp/audio_pd"; > + q6prmcc: clock-controller { > + compatible = "qcom,q6prm-lpass-clocks"; > + clock-controller; > + #clock-cells = <2>; > + }; > + }; > + }; > }; > }; > > + Drop the stray newline. > usb_0_qmpphy: phy-wrapper@88ec000 { > compatible = "qcom,sc8280xp-qmp-usb43dp-phy"; > reg = <0 0x088ec000 0 0x1e4>, Johan