On 17/11/2022 15:28, Stephan Gerhold wrote: > On Thu, Nov 17, 2022 at 02:02:54PM +0100, Krzysztof Kozlowski wrote: >> Most of the device-specific compatibles have generic fallbacks like >> qcom,tsens-v1 or qcom,tsens-v2. The if:then: block mentions these >> fallbacks, so drop redundant entries for specific compatibles. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- >> >> Cc: Neil Armstrong <neil.armstrong@xxxxxxxxxx> >> --- >> .../devicetree/bindings/thermal/qcom-tsens.yaml | 16 ---------------- >> 1 file changed, 16 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> index f0bd4b979e28..c9949713f714 100644 >> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml >> @@ -118,12 +118,7 @@ allOf: >> contains: >> enum: >> - qcom,ipq8064-tsens >> - - qcom,mdm9607-tsens >> - - qcom,msm8916-tsens >> - qcom,msm8960-tsens >> - - qcom,msm8974-tsens >> - - qcom,msm8976-tsens >> - - qcom,qcs404-tsens >> - qcom,tsens-v0_1 >> - qcom,tsens-v1 >> then: > > FWIW: I submitted the same patch for this part a couple of months ago, > it was never applied for some reason: > https://lore.kernel.org/linux-arm-msm/20220627131415.2868938-2-stephan.gerhold@xxxxxxxxxxxxxxx/ Indeed, somehow Daniel didn't take it. Your patch should go instead, if you rebase and include new hunks (like my patch). > >> @@ -140,17 +135,6 @@ allOf: >> compatible: >> contains: >> enum: >> - - qcom,msm8953-tsens >> - - qcom,msm8996-tsens >> - - qcom,msm8998-tsens >> - - qcom,sc7180-tsens >> - - qcom,sc7280-tsens >> - - qcom,sc8180x-tsens >> - - qcom,sdm630-tsens >> - - qcom,sdm845-tsens >> - - qcom,sm8150-tsens >> - - qcom,sm8250-tsens >> - - qcom,sm8350-tsens >> - qcom,tsens-v2 >> then: >> properties: >> > > This part was not present back then though. Looks like this was > introduced recently in "dt-bindings: thermal: tsens: Add ipq8074 > compatible". > > I don't mind if you take this patch instead of mine. Feel free to add my > > Reviewed-by: Stephan Gerhold <stephan@xxxxxxxxxxx> > > Thanks, > Stephan Best regards, Krzysztof
