On 11/11/2022 10:24, Johan Hovold wrote: > The current QMP USB3-DP PHY bindings are based on the original MSM8996 > binding which provided multiple PHYs per IP block and these in turn were > described by child nodes. > Thank you for your patch. There is something to discuss/improve. > + > +maintainers: > + - Vinod Koul <vkoul@xxxxxxxxxx> Maybe you want to add also yourself? > + > +description: > + The QMP PHY controller supports physical layer functionality for a number of > + controllers on Qualcomm chipsets, such as, PCIe, UFS and USB. > + > + See also: > + - include/dt-bindings/dt-bindings/phy/phy.h > + > +properties: > + compatible: > + enum: > + - qcom,sc8280xp-qmp-usb43dp-phy > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: aux > + - const: ref > + - const: com_aux > + - const: usb3_pipe > + > + power-domains: > + maxItems: 1 > + > + resets: > + maxItems: 2 > + > + reset-names: > + items: > + - const: phy > + - const: common > + > + vdda-phy-supply: true > + > + vdda-pll-supply: true > + > + "#clock-cells": > + const: 1 > + > + clock-output-names: > + items: > + - const: usb3_pipe > + - const: dp_link > + - const: dp_vco_div Why defining here fixed names? The purpose of this field is to actually allow customizing these - at least in most cases. If these have to be fixed, then driver should just instantiate these clocks with such names, right? Best regards, Krzysztof
