On 11/11/2022 14:30, Rob Herring wrote: > > On Fri, 11 Nov 2022 12:35:39 +0100, Krzysztof Kozlowski wrote: >> The APR/GPR nodes are organized like: >> >> apr-or-gpr-device-node <- qcom,apr.yaml >> apr-gpr-service@[0-9] <- qcom,apr.yaml >> service-specific-components <- /schemas/sound/qcom,q6*.yaml >> >> The schema for services (apr-gpr-service@[0-9]) already grows >> considerably and is still quite not specific. It allows several >> incorrect combinations, like adding a clock-controller to a APM device. >> Restricting it would complicate the schema even more. Bringing new >> support for sound on Qualcomm SM8450 and SC8280XP SoC would grow it as >> well. >> >> Simplify the qcom,apr.yaml by splitting the services to a shared file >> which will be: >> 1. Referenced by qcom,apr.yaml with additionalProperties:true, >> 2. Referenced by specific bindings for services with >> additionalProperties:false (not yet in this commit). >> >> While moving the code, add also required 'reg' and >> 'qcom,protection-domain' to further constrain the bindings. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- >> .../bindings/soc/qcom/qcom,apr-services.yaml | 54 +++++++++ >> .../bindings/soc/qcom/qcom,apr.yaml | 108 +----------------- >> MAINTAINERS | 2 +- >> 3 files changed, 58 insertions(+), 106 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@3: failed to match any schema with compatible: ['qcom,q6core'] > Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@4: failed to match any schema with compatible: ['qcom,q6afe'] > Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@7: failed to match any schema with compatible: ['qcom,q6asm'] > Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb:0:0: /example-0/apr/service@8: failed to match any schema with compatible: ['qcom,q6adm'] This is expected. I should have mention maybe in commit msg that these compatibles are being removed in this commit and re-added in further commits. Change is therefore not entirely bisectable, but should be easier for review. If desired, I can squash these commits. Best regards, Krzysztof
