On 09/11/2022 21:48, Marijn Suijten wrote: > On 2022-11-09 12:33:37, Marijn Suijten wrote: >> On 2022-11-08 15:09:09, Krzysztof Kozlowski wrote: >>> Convert Qualcomm MSM8976 pin controller bindings to DT schema. Keep the >>> parsing of pin configuration subnodes consistent with other Qualcomm >>> schemas (children named with '-state' suffix, their children with >>> '-pins'). >>> >>> Changes during conversion: update the list of non-mux pins (like sdc1) >>> to match Linux driver. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> Thanks for sending this right as we are upstreaming MSM8976! With one >> question and one nit below: >> >> Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > I retract my review on this patch, see below. > >>> [..] >>> + items: >>> + oneOf: >>> + - pattern: "^gpio([0-9]|[1-9][0-9]|1[0-3][0-9]|14[0-4])$" >>> + - enum: [ qdsd_clk, qdsd_cmd, qdsd_data0, qdsd_data1, qdsd_data2, >>> + qdsd_data3 sdc1_clk, sdc1_cmd, sdc1_data, sdc1_rclk, > > Missing a comma between 'qdsd_data3' and 'sdc1_clk', making the bindings > checker treat this as a single string 'qdsd_data3 sdc1_clk'. Good point, thanks! Best regards, Krzysztof
