Re: [PATCH v5] bus: mhi: host: make mhi_controller_config::event_cfg const

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 08, 2022 at 08:09:02PM +0530, Manivannan Sadhasivam wrote:
> On Tue, Nov 08, 2022 at 03:33:35PM +0200, Kalle Valo wrote:
> > Manivannan Sadhasivam <mani@xxxxxxxxxx> writes:
> > 
> > > On Tue, Aug 30, 2022 at 10:11:47AM -0700, Jeff Johnson wrote:
> > >> Currently the event_cfg pointer in struct mhi_controller_config is not
> > >> defined as a const pointer. This prevents clients from registering a
> > >> read-only configuration unless they use a typecast. Since the
> > >> event_cfg should not be modified once registered, add the const
> > >> qualifier to event_cfg. This is aligned with the definition of ch_cfg.
> > >> 
> > >> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
> > >
> > > Applied to mhi-next!
> > 
> > BTW what happened to this patch? I cannot find it anywhere.
> > 
> 
> Sorry! I did apply this patch earlier locally but didn't push it to
> remote. So it got lost.
> 
> Now pushed! Thanks for spotting.
> 

Dropped the patch now because of this: https://lore.kernel.org/lkml/20221109151637.67be60f8@xxxxxxxxxxxxxxxx/

Since we need to modify event_cfg for using the shared IRQ, I don't think the
patch is applicable. Maybe that's the reason I dropped it earlier also, but
forgot to share it in mailing list.

Thanks,
Mani

> > -- 
> > https://patchwork.kernel.org/project/linux-wireless/list/
> > 
> > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
> > 
> 
> -- 
> மணிவண்ணன் சதாசிவம்
> 

-- 
மணிவண்ணன் சதாசிவம்



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux