On 08/11/2022 00:24, Doug Anderson wrote:
This seems fine, but I don't think it matches your bindings. Your
bindings says you can have one compatible string. It could be
"qcom,mdss-dsi-ctrl-sc7180" or it could be "qcom,mdss-dsi-ctrl".
...but your device tree has two compatible strings: the SoC specific
one and the fallback one. You need to change your bindings to make
this work.
With the update in this series the binding has a required const.
If you drop back to just "qcom,mdss-dsi-ctrl-sc7180" you get a warning
like this.
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb: dsi@ae94000:
compatible: ['qcom,mdss-dsi-ctrl-sc7180'] is too short
If you just have 'qcom,mdss-dsi-ctrl' you get
arch/arm64/boot/dts/qcom/sc7180-trogdor-homestar-r4.dtb: dsi@ae94000:
compatible:0: 'qcom,mdss-dsi-ctrl' is not one of
['qcom,dsi-ctrl-6g-qcm2290', 'qcom,mdss-dsi-ctrl-apq8064',
'qcom,mdss-dsi-ctrl-msm8916', 'qcom,mdss-dsi-ctrl-msm8974',
'qcom,mdss-dsi-ctrl-msm8996', 'qcom,mdss-dsi-ctrl-sc7180',
'qcom,mdss-dsi-ctrl-sc7280', 'qcom,mdss-dsi-ctrl-sdm630',
'qcom,mdss-dsi-ctrl-sdm660', 'qcom,mdss-dsi-ctrl-sdm845',
'qcom,mdss-dsi-ctrl-sm8250']
---
bod
