On 08/11/2022 11:10, Sibi Sankar wrote: > Krzysztof, > Thanks for taking time to review the series. > > > On 11/8/22 15:04, Krzysztof Kozlowski wrote: >> On 08/11/2022 10:22, Sibi Sankar wrote: >>> When the modem node was re-located to a separate LTE source file >>> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users >>> weren't marked appropriately. Fix this by marking all Qualcomm >>> reference devices as LTE. >>> >>> Fix-suggested-by: Douglas Anderson <dianders@xxxxxxxxxxxx> >> >> There is no such tag. If it is a fix, use Reported-by. If it is not, use >> Suggested-by. > > lol I should have just stuck with S-b but found the tag being used a > number of times. I'll fix this up if the series warrants a re-spin. It indeed appears in the log. Once (since v5.15). So that's a mistake, not practice. Common tags are described here: - Documentation/process/submitting-patches.rst - scripts/checkpatch.pl Best regards, Krzysztof