On Mon, 7 Nov 2022 09:44:03 +0800, Jiasheng Jiang wrote: > As idr_alloc() and of_property_read_string_index() can return negative > numbers, it should be better to check the return value and deal with > the exception. > Therefore, it should be better to use goto statement to stop and return > error. > > > [...] Applied, thanks! [1/1] soc: qcom: apr: Add check for idr_alloc and of_property_read_string_index commit: 6d7860f5750d73da2fa1a1f6c9405058a593fa32 Best regards, -- Bjorn Andersson <andersson@xxxxxxxxxx>