On 11/7/22 20:25, Daniel Vetter wrote: >> Move dma_buf_mmap() function to the dynamic locking specification by >> taking the reservation lock. Neither of the today's drivers take the >> reservation lock within the mmap() callback, hence it's safe to enforce >> the locking. >> >> Acked-by: Sumit Semwal <sumit.semwal@xxxxxxxxxx> >> Acked-by: Christian König <christian.koenig@xxxxxxx> >> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx> > Just noticed this while reading code ... this patch seems to have > missed dma_buf_mmap_internal()? > > Might be good if at least some drivers gain a dma_resv_assert_held in > that path to make sure we're not quite this bad, together with fixing > this issue. Good catch! I'll prepare the patches. -- Best regards, Dmitry
