On 04/11/2022 13:21, AngeloGioacchino Del Regno wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
>
> This adds support for the Sony Xperia Loire/SmartLoire platform
Thank you for your patch. There is something to discuss/improve.
> +
> +&rpm_requests {
> + pm8950_regulators: regulators {
> + compatible = "qcom,rpm-pm8950-regulators";
> +
> + vdd_s1-supply = <&vph_pwr>;
> + vdd_s2-supply = <&vph_pwr>;
> + vdd_s3-supply = <&vph_pwr>;
> + vdd_s4-supply = <&vph_pwr>;
> + vdd_s6-supply = <&vph_pwr>;
> + vdd_l1_l19-supply = <&pm8950_s3>;
> + vdd_l2_l23-supply = <&pm8950_s3>;
> + vdd_l3-supply = <&pm8950_s3>;
> + vdd_l5_l6_l7_l16-supply = <&pm8950_s4>;
> + vdd_l8_l11_l12_l17_l22-supply = <&vph_pwr>;
> +
> + pm8950_s1: s1 {
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1162500>;
> + };
> +
> + pm8950_s3: s3 {
> + regulator-min-microvolt = <1325000>;
> + regulator-max-microvolt = <1325000>;
> + regulator-always-on;
> + };
> +
> + pm8950_s4: s4 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> + pm8950_l1: l1 {
> + regulator-min-microvolt = <900000>;
> + regulator-max-microvolt = <1100000>;
> + };
> +
> + pm8950_l2: l2 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + };
> +
> + pm8950_l3: l3 {
> + regulator-min-microvolt = <1000000>;
> + regulator-max-microvolt = <1200000>;
> + };
> +
> + pm8950_l5: l5 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + pm8950_l6: l6 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + pm8950_l7: l7 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + pm8950_l8: l8 {
> + regulator-min-microvolt = <2900000>;
> + regulator-max-microvolt = <2900000>;
> + };
> +
> + pm8950_l9: l9 {
> + regulator-min-microvolt = <2000000>;
> + regulator-max-microvolt = <2400000>;
> + };
> +
> + pm8950_l10: l10 {
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2900000>;
> + };
> +
> + pm8950_l11: l11 {
> + regulator-min-microvolt = <2950000>;
> + regulator-max-microvolt = <2950000>;
> + };
> +
> + pm8950_l12: l12 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <2950000>;
> + };
> +
> + pm8950_l13: l13 {
> + regulator-min-microvolt = <3075000>;
> + regulator-max-microvolt = <3075000>;
> + };
> +
> + pm8950_l14: l14 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + pm8950_l15: l15 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + };
> +
> + pm8950_l16: l16 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> +
> + pm8950_l17: l17 {
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2900000>;
> + };
> +
> + pm8950_l22: l22 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + };
> +
> + pm8950_l23: l23 {
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + };
> + };
> +};
> +
> +&sdhc_1 {
> + status = "okay";
Status as last (everywhere)
https://lore.kernel.org/all/5158fe83-88b1-1081-df7f-4118ce6f5ec0@xxxxxxxxxxxxxx/
Rest LGTM.
Best regards,
Krzysztof
