On 04/11/2022 09:35, AngeloGioacchino Del Regno wrote: > Document bindings for the Qualcomm Ramp Controller, found on various > legacy Qualcomm SoCs. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > --- > .../soc/qcom/qcom,ramp-controller.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml Filename based on compatible, so qcom,msm8976-ramp-controller.yaml > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml > new file mode 100644 > index 000000000000..95ce48cfca4e > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,ramp-controller.yaml > @@ -0,0 +1,42 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/qcom/qcom,ramp-controller.yaml#"; > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"; Drop quotes from both lines above. > + > +title: Qualcomm Ramp Controller > + > +maintainers: > + - AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> > + > +description: > + The Ramp Controller is used to program the sequence ID for pulse > + swallowing, enable sequences and linking Sequence IDs (SIDs) for s/linking/link/ if I understand the sentence correctly (is used to: program, enable and link) > + the CPU cores on some Qualcomm SoCs. > + > +properties: > + compatible: > + items: Drop items. > + enum: I also think you did not test it... > + - qcom,msm8976-ramp-controller > + > + reg: > + maxItems: 1 > + Best regards, Krzysztof
