On 02/11/2022 18:08, Dmitry Baryshkov wrote:
> Convert the mdp5.txt into the yaml format. Changes to the existing (txt) schema:
> - MSM8996 has additional "iommu" clock, define it separately
> - Add new properties used on some of platforms:
> - interconnects, interconnect-names
> - iommus
> - power-domains
> - operating-points-v2, opp-table
>
Thank you for your patch. There is something to discuss/improve.
> +
> + clock-names:
> + oneOf:
> + - minItems: 4
> + items:
> + - const: iface
> + - const: bus
> + - const: core
> + - const: vsync
> + - const: lut
> + - const: tbu
> + - const: tbu_rt
> + #MSM8996 has additional iommu clock
> + - items:
> + - const: iface
> + - const: bus
> + - const: core
> + - const: iommu
> + - const: vsync
> +
> + interconnects:
> + minItems: 1
> + items:
> + - description: Interconnect path from mdp0 (or a single mdp) port to the data bus
> + - description: Interconnect path from mdp1 port to the data bus
> + - description: Interconnect path from rotator port to the data bus
> +
> + interconnect-names:
> + minItems: 1
> + items:
> + - const: mdp0-mem
> + - const: mdp1-mem
> + - const: rotator-mem
> +
> + iommus:
> + items:
> + - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0
> +
> + power-domains:
> + maxItems: 1
> +
> + operating-points-v2: true
> + opp-table:
> + type: object
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> + description: |
> + Contains the list of output ports from DPU device. These ports
> + connect to interfaces that are external to the DPU hardware,
> + such as DSI, DP etc.
You could include here information about number of ports per variant.
> +
> + patternProperties:
> + "^port@[0-9a-f]+$":
[0-3]
> + $ref: /schemas/graph.yaml#/properties/port
> +
> + # at least one port is required
> + required:
> + - port@0
> +
> +required:
> + - compatible
> + - reg
> + - reg-names
> + - clocks
> + - clock-names
> + - ports
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,gcc-msm8916.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + mdp@1a01000 {
display-controller@......
> + compatible = "qcom,mdp5";
> + reg = <0x1a01000 0x90000>;
> + reg-names = "mdp_phys";
> +
Best regards,
Krzysztof
