On 27/10/2022 23:41, Bjorn Andersson wrote: > Add EPSS L3 compatibles for sm8350 and sc8280xp, but while at it also > introduce generic compatible for both qcom,osm-l3 and qcom,epss-l3. > > Signed-off-by: Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> > --- > .../bindings/interconnect/qcom,osm-l3.yaml | 22 +++++++++++++------ > 1 file changed, 15 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > index bf538c0c5a81..ae0995341a78 100644 > --- a/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > +++ b/Documentation/devicetree/bindings/interconnect/qcom,osm-l3.yaml > @@ -16,13 +16,21 @@ description: > > properties: > compatible: > - enum: > - - qcom,sc7180-osm-l3 > - - qcom,sc7280-epss-l3 > - - qcom,sc8180x-osm-l3 > - - qcom,sdm845-osm-l3 > - - qcom,sm8150-osm-l3 > - - qcom,sm8250-epss-l3 > + oneOf: > + items: oneOf expects a list, so this should be " - items" > + - enum: > + - qcom,sc7180-osm-l3 > + - qcom,sc8180x-osm-l3 > + - qcom,sdm845-osm-l3 > + - qcom,sm8150-osm-l3 > + - const: qcom,osm-l3 The concept is good, but are you sure all SoCs will be compatible with generic osm-l3? Why not using dedicated compatible of one soc, e.g. the oldest here? We already did like that for BWMON, DMA and few others. > + items: > + - enum: > + - qcom,sc7280-epss-l3 > + - qcom,sc8280xp-epss-l3 > + - qcom,sm8250-epss-l3 > + - qcom,sm8350-epss-l3 > + - const: qcom,epss-l3 > > reg: > maxItems: 1 Best regards, Krzysztof
