On 10/20/22 11:03, Asutosh Das wrote:
Add support for completing requests from Completion Queue. Some HC support vendor specific registers that provide a bit-map of all CQ's which have at least one completed CQE. Add this support. The MCQ specification doesn't provide the Task Tag or its equivalent in the Completion Queue Entry. So use an indirect method to find the Task Tag from the Completion Queue Entry.
Please change "HC" into "host controllers" since it is an uncommon abbreviation.
+ int tag; + + tag = ufshcd_mcq_get_tag(hba, hwq, cqe);
Please combine the above declaration and assignment into a single line. Otherwise this patch looks good to me. Hence: Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>