Re: [PATCH v3 12/17] ufs: core: mcq: Find hardware queue to queue request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/20/22 11:03, Asutosh Das wrote:
+struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba,
+					 struct request *req)
+{
+	u32 utag, hwq;
+
+	utag = blk_mq_unique_tag(req);
+	hwq = blk_mq_unique_tag_to_hwq(utag);

A minor stylistic nit: please combine declaration and assignment as follows:

        u32 utag = blk_mq_unique_tag(req);
        u32 hwq = blk_mq_unique_tag_to_hwq(utag);

+	/* uhq[0] is to serve device commands */

is -> is used?

+	return &hba->uhq[hwq + UFSHCD_MCQ_IO_QUEUE_OFFSET];

Otherwise this patch looks good to me. Hence:

Reviewed-by: Bart Van Assche <bvanassche@xxxxxxx>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux