On 27/10/2022 21:04, Melody Olvera wrote: > > > On 10/27/2022 8:57 AM, Krzysztof Kozlowski wrote: >> On 26/10/2022 15:04, Melody Olvera wrote: >>> Add compatible strings for RPMHCC for QDU1000 and QRU1000. >>> >>> Signed-off-by: Melody Olvera <quic_molvera@xxxxxxxxxxx> >>> --- >> This looks correct except: >> 1. redundant bindings in subject >> 2. not cc-ing all maintainers >> >> so still not tag. >> >> > Not sure what you mean by redundant bindings; should I remove > "QRU1000"? "Compatible strings"? Please advise. In the subject please drop second 'bindings' word, because it is redundant so: dt-bindings: clock: Add RPMHCC for QDU1000 and QRU1000 or dt-bindings: clock: Add QDU1000/QRU1000 RPMHCC > > Also, I got maintainers from running get_maintainers.pl on > linux-next/master; is this wrong? Not sure what I'm missing here. You miss some of Qualcomm maintainers. Maybe more, I did not check every possible output for every patchset. I just spotted missing Konrad, because it sticks out. If you copy the output of some commands, be sure you copy everything. Otherwise, just automate it so there will be no chances for mistakes. Best regards, Krzysztof
