On Thu, Oct 27, 2022 at 12:16:25PM -0700, Nathan Chancellor wrote: > When building ARCH=arm allmodconfig, the following error occurs: > > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_gpio_set_mux’: > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:102:9: error: implicit declaration of function ‘u32p_replace_bits’ [-Werror=implicit-function-declaration] > 102 | u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK); > | ^~~~~~~~~~~~~~~~~ > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_get’: > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:127:16: error: implicit declaration of function ‘FIELD_GET’ [-Werror=implicit-function-declaration] > 127 | pull = FIELD_GET(LPI_GPIO_PULL_MASK, ctl_reg); > | ^~~~~~~~~ > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c: In function ‘lpi_config_set’: > drivers/pinctrl/qcom/pinctrl-lpass-lpi.c:233:23: error: implicit declaration of function ‘u32_encode_bits’ [-Werror=implicit-function-declaration] > 233 | val = u32_encode_bits(value ? 1 : 0, LPI_GPIO_VALUE_OUT_MASK); > | ^~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > bitfield.h was included via pinctrl-lpass-lpi.h but another change > removed that include to restrict what was being included. Add bitfield.h > back to pinctrl-lpass-lpi.c, as it is needed there. Thanks, https://lore.kernel.org/linux-gpio/20221027184145.2533-1-andriy.shevchenko@xxxxxxxxxxxxxxx/ -- With Best Regards, Andy Shevchenko
