Re: Fwd: [PATCH v2 06/17] ufs: core: mcq: Configure resource regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Asutosh,

On Mon, 2022-10-17 at 18:47 -0700, Asutosh Das wrote:
> > 
> On Mon, Oct 17 2022 at 02:27 -0700, Eddie Huang wrote:
> > Hi Can,
> > 
> 
> [...]
> 
> > We treat UFS as a single IP, so we suggest:
> > 1. Map whole UFS register (include MCQ) in ufshcd_pltfrm_init()
> > 2. In ufshcd_mcq_config_resource() assign mcq_base address
> > directly,
> > ie,
> >     hba->mcq_base = hba->mmio_base + MCQ_SQATTR_OFFSET(hba-
> > > mcq_capabilities)
> > 
> > 3. In ufshcd_mcq_vops_op_runtime_config(), assign SQD, SQIS, CQD,
> > CQIS
> > base, offset and stride
> > 
> > This is why I propose ufshcd_mcq_config_resource() to be
> > customized,
> > not in common code
> 
> How about we add a vops to ufshcd_mcq_config_resource().
> SoC vendors should make sure that the vops populates the mcq_base.
> 

It is good to add vops to ufshcd_mcq_config_resource() let SoC vendors 
populate mcq_base


Thanks,
Eddie Huang





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux