On 2022-10-11 08:06:55, Krzysztof Kozlowski wrote: > On 11/10/2022 03:45, Marijn Suijten wrote: > > On 2022-09-30 21:29:48, Krzysztof Kozlowski wrote: > >> DT schema expects TLMM pin configuration nodes to be named with > >> '-state' suffix and their optional children with '-pins' suffix. > >> > >> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > > Thanks! > > > > Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> > > > > Perhaps mention more clearly that this is fixing up an earlier patch > > that tried to address missing `-pins`? > > It is not fixing only that patch, but also nodes added later without suffix. Afaik the node was already there when [1] was applied, it just accidentally added -pins to cmd twice instead of once to clk and cmd separately. But feel free to stick to a generic commit message. [1]: https://lore.kernel.org/all/20220912061746.6311-35-krzysztof.kozlowski@xxxxxxxxxx/ - Marijn
