On Tue, Oct 11, 2022 at 05:07:16PM +0300, Dmitry Baryshkov wrote: > On 11/10/2022 16:14, Johan Hovold wrote: > > The SC8280XP combo PHY does not need a delay before starting the USB PHY > > (which is what the has_pwrdn_delay config option really controls) so > > drop the unnecessary delay. > > > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > > --- > > drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 4 ---- > > 1 file changed, 4 deletions(-) > > Just an obvious question: 'does not need a delay' comes from your > experience or from some vendor flag (in ACPI/DT/kernel/wherever)? There's no corresponding delay in the vendor driver; the delay as it is used in the driver (before starting the PHY) makes no sense and shouldn't be used for new platforms; and I've verified that it isn't needed on SC8280XP. I'm confident that this was just another case of copy-pasting. And the buck stops here (with SC8280XP). ;) Johan
