On 10/10/22 22:14, Andy Shevchenko wrote: > Do not imply that some of the generic headers may be always included. > Instead, include explicitly what we are direct user of. > > While at it, sort headers alphabetically. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > --- > drivers/pinctrl/pinctrl-st.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index cf7f9cbe6044..985dfceb127d 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -5,21 +5,26 @@ > * Srinivas Kandagatla <srinivas.kandagatla@xxxxxx> > */ > > -#include <linux/init.h> > -#include <linux/module.h> > -#include <linux/slab.h> > #include <linux/err.h> > +#include <linux/gpio/driver.h> > +#include <linux/init.h> > #include <linux/io.h> > +#include <linux/mfd/syscon.h> > +#include <linux/module.h> > #include <linux/of.h> > -#include <linux/of_irq.h> > #include <linux/of_address.h> > -#include <linux/gpio/driver.h> > +#include <linux/of_irq.h> > +#include <linux/platform_device.h> > #include <linux/regmap.h> > -#include <linux/mfd/syscon.h> > +#include <linux/seq_file.h> > +#include <linux/slab.h> > +#include <linux/string_helpers.h> > + > +#include <linux/pinctrl/consumer.h> > +#include <linux/pinctrl/pinconf.h> > #include <linux/pinctrl/pinctrl.h> > #include <linux/pinctrl/pinmux.h> > -#include <linux/pinctrl/pinconf.h> > -#include <linux/platform_device.h> > + > #include "core.h" > > /* PIO Block registers */ Reviewed-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx> Thanks Patrice
