Re: [PATCH 1/2] dt-bindings: soc: qcom: YAML-ify SSBI bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 03/10/2022 19:17, Rob Herring wrote:
> On Mon, Oct 03, 2022 at 08:46:09AM +0200, Krzysztof Kozlowski wrote:
>> On 02/10/2022 15:46, Dmitry Baryshkov wrote:
>>>>> +    enum:
>>>>> +      - ssbi
>>>>> +      - ssbi2
>>>>> +      - pmic-arbiter
>>>>> +
>>>>> +  pmic:
>>>>> +    type: object
>>>>
>>>> This is quite unspecific... Can we make it a ref to some PMICs schemas?
>>>
>>> Yes, I thought about listing all compats, but probably a $ref:
>>> ../mfd/qcom-pm8xxx.yaml# makes more sense.
>>
>> Then full path - /schemas/mfd/qcom-....
> 
> While effectively it's always a QCom PMIC, this is a bus binding, so 
> shouldn't it just be 'additionalProperties: { type: object }' without 
> any reference to the type of device?

If we treat it as generic bus, then maybe also "pmic" is not
appropriate. What if other devices are connected?

Bindings were saying it is Qualcomm SoC specific bus, so I don't think
we can have here anything else than Qualcomm PMIC.

Best regards,
Krzysztof




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux