On 30.09.2022 22:19, Krzysztof Kozlowski wrote: > On 30/09/2022 22:13, Konrad Dybcio wrote: >> >> >> On 30.09.2022 22:05, Krzysztof Kozlowski wrote: >>> DT schema expects TLMM pin configuration nodes to be named with >>> '-state' suffix and their optional children with '-pins' suffix. >>> >>> The sdm854.dtsi file defined several pin configuration nodes which are >> 845 >> >>> customized by the boards. Therefore keep a additional "default-pins" >>> node inside so the boards can add more of configuration nodes. Such >>> additional configuration nodes always need 'function' property now >>> (required by DT schema). >> Would it not make more sense to drop this and keep the properties in the >> root node while at it? >> >> Konrad > > Not possible, because the boards set different bias/config for the pins: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845.dtsi?h=v6.0-rc7#n2988 > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/sdm845-mtp.dts?h=v6.0-rc7#n729 > Ok, I see now. Konrad > Best regards, > Krzysztof >
