On 28/09/2022 11:14, Neil Armstrong wrote: > The PMIC is an PM8018, but was compatible with the PM8921. Both compatibles > was left but it makes no sense anymore the leave both. Why? It makes sense for backwards compatibility. If you think it does not make sense, please say why. > > The pwrkey compatible is left to PM8921, unlike the others because > the interface is stricly compatible with the PM9821 pwrkey. typo: strictly typo: PM8921 Again, why? The old code looked correct. In all three places. > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > Best regards, Krzysztof