On 9/26/2022 2:30 PM, Krzysztof Kozlowski wrote:
On 26/09/2022 06:57, Manikanta Pubbisetty wrote:
Add DT nodes to support WoW (Wake on Wireless) feature on WCN6750
WiFi hardware on SC7280 SoC.
Signed-off-by: Manikanta Pubbisetty <quic_mpubbise@xxxxxxxxxxx>
Thank you for your patch. There is something to discuss/improve.
---
Changes from V1:
- Rebased on ToT
arch/arm64/boot/dts/qcom/sc7280.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 212580316d3e..3f6a3f575339 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -752,6 +752,17 @@ wpss_smp2p_in: slave-kernel {
interrupt-controller;
#interrupt-cells = <2>;
};
+
+ wlan_smp2p_out: wlan-ap-to-wpss {
Does not look like you tested the DTS against bindings. Please run `make
dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst
for instructions).
I'm sorry I was not aware of checking the DTS against bindings. I'll do
the due diligence going forward. `make dtbs_check is throwing error of
"No rule to make target". Not sure if we need pass any options to the
command. I did try to understand the problem but all went in vain. Pls
help understand if I'm missing anything.
+ qcom,entry-name = "wlan";
+ #qcom,smem-state-cells = <1>;
+ };
+
+ wlan_smp2p_in: wlan-wpss-to-ap {
+ qcom,entry-name = "wlan";
+ interrupt-controller;
+ #interrupt-cells = <2>;
+ };
};
pmu {
@@ -2004,6 +2015,8 @@ wifi: wifi@17a10040 {
qcom,rproc = <&remoteproc_wpss>;
memory-region = <&wlan_fw_mem>, <&wlan_ce_mem>;
status = "disabled";
status is the last.
Sure.
+ qcom,smem-states = <&wlan_smp2p_out 0>;
+ qcom,smem-state-names = "wlan-smp2p-out";
Are these valid properties for this node? Did you check with bindings?
These are valid properties IIUC. Pls help check the binding here
https://patchwork.kernel.org/project/linux-wireless/patch/20220902112520.24804-2-quic_mpubbise@xxxxxxxxxxx/
.
Thanks,
Manikanta
