On Sat, 24 Sept 2022 at 11:07, Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > Certain pins, like SDcard related, do not have functions and such should > not be required. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- > .../bindings/pinctrl/qcom,qcm2290-pinctrl.yaml | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > index 5324b61eb4f7..89453cb60c12 100644 > --- a/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcm2290-pinctrl.yaml > @@ -60,7 +60,6 @@ patternProperties: > description: > Pinctrl node's client devices use subnodes for desired pin configuration. > Client device subnodes use below standard properties. > - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > > properties: > pins: > @@ -116,6 +115,16 @@ patternProperties: > required: > - pins > > + allOf: Nit: I think you can drop allOf here and move the $ref up a few lines. > + - $ref: "qcom,tlmm-common.yaml#/$defs/qcom-tlmm-state" > + - if: > + properties: > + pins: > + pattern: "^gpio([0-9]|[1-9][0-9]|1[0-1][0-9]|12[0-6])$" > + then: > + required: > + - function > + > additionalProperties: false > > allOf: > -- > 2.34.1 > -- With best wishes Dmitry
