On Mon, Sep 26, 2022 at 08:34:34PM +0300, Dmitry Baryshkov wrote: > Call phy_set_mode_ext() to notify the PHY driver that the PHY is being > used in the RC mode. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx> I believe you forgot to add Jingoo Han's tag: https://lore.kernel.org/all/CAPOBaE548e669mbg5vM+ZoAgOz+g4eKRRODcRXRX-r+cdMf1yQ@xxxxxxxxxxxxxx/ > --- > drivers/pci/controller/dwc/pcie-qcom.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 66886dc6e777..1027281bd6ff 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -22,6 +22,7 @@ > #include <linux/pci.h> > #include <linux/pm_runtime.h> > #include <linux/platform_device.h> > +#include <linux/phy/pcie.h> > #include <linux/phy/phy.h> > #include <linux/regulator/consumer.h> > #include <linux/reset.h> > @@ -1494,6 +1495,10 @@ static int qcom_pcie_host_init(struct dw_pcie_rp *pp) > if (ret) > return ret; > > + ret = phy_set_mode_ext(pcie->phy, PHY_MODE_PCIE, PHY_MODE_PCIE_RC); > + if (ret) > + goto err_deinit; > + > ret = phy_power_on(pcie->phy); > if (ret) > goto err_deinit; Johan
