Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/13/2022 1:53 AM, Johan Hovold wrote:
Drop the overly defensive modeset sanity checks of function parameters
which have already been checked or used by the callers.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>

The change LGTM, hence

Reviewed-by: Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>

I think we can use below fixes tag so that we can pick up this entire series for the fixes cycle.

Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support")

---
  drivers/gpu/drm/msm/dp/dp_display.c | 7 +------
  1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index 808a516e84c5..33daec11f813 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -1607,15 +1607,10 @@ static int dp_display_get_next_bridge(struct msm_dp *dp)
  int msm_dp_modeset_init(struct msm_dp *dp_display, struct drm_device *dev,
  			struct drm_encoder *encoder)
  {
-	struct msm_drm_private *priv;
+	struct msm_drm_private *priv = dev->dev_private;
  	struct dp_display_private *dp_priv;
  	int ret;
- if (WARN_ON(!encoder) || WARN_ON(!dp_display) || WARN_ON(!dev))
-		return -EINVAL;
-
-	priv = dev->dev_private;
-
  	if (priv->num_bridges == ARRAY_SIZE(priv->bridges)) {
  		DRM_DEV_ERROR(dev->dev, "too many bridges\n");
  		return -ENOSPC;



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux