On Sat, Sep 24, 2022 at 11:18:12AM +0530, Vinod Koul wrote: > On 14-09-22, 08:48, Johan Hovold wrote: > > On Fri, Sep 09, 2022 at 12:14:24PM +0300, Dmitry Baryshkov wrote: > > > > Changes since v2: > > > - Added PHY_SUBMODE_PCIE_RC/EP defines (Vinod), > > > - Changed `primary' table name to `main', added extra comments > > > describing that `secondary' are the additional tables, not required in > > > most of the cases (following the suggestion by Johan to rename > > > `primary' table), > > > > This wasn't really what I suggested. "main" is in itself is no more > > understandable than "primary". > > > > Please take another look at: > > > > https://lore.kernel.org/all/Yw2+aVbqBfMSUcWq@xxxxxxxxxxxxxxxxxxxx/ > > Am not sure example quoted there was very initutive: > "as the tables can be referred to as > > cfg.tbls2.serdes > > instead of > > cfg.secondary.serdes_tbl;" The main point was that "secondary" doesn't say anything about what the variable is used for (unlike for example "secondary_tbls") and that keeping a "_tbl" suffix on every member in a structure that holds only tables is redundant. > I would agree with Johan that primary and secondary are too long, but > that tbls2 is not very intuitive either... That could be cfg.tbls_extra.serdes; too or whatever. The key point was to have a descriptive name of the tables-structure variable and dropping "_tbl" from the individual members. Johan
