On Wed, 21 Sep 2022, Caleb Connolly wrote: > > > On 21/09/2022 07:12, Luca Weiss wrote: > > Hi Lee, hi Caleb > > > > On Tue Sep 20, 2022 at 9:50 AM CEST, Lee Jones wrote: > > > On Thu, 15 Sep 2022, Luca Weiss wrote: > > > > > > > There are some IDs that are written in uppercase. For consistency > > > > convert them to lowercase. > > > > > > > > Signed-off-by: Luca Weiss <luca.weiss@xxxxxxxxxxxxx> > > > > --- > > > > Changes since v2: > > > > * Split out to separate patch > > > > > > > > include/soc/qcom/qcom-spmi-pmic.h | 6 +++--- > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > These aren't MFD patches. Please reword the subject. > > > > Do you have any suggestion what subject to use then? The most I can > > think of is "soc: qcom: " which is sometimes used for other files in > > this include directory. > > I've used the current subject because the previous two patches touching > > this file had this subject also. > > This file just contains platform data which used to be in the qcom SPMI > PMIC driver. In hindsight, maybe it would have been better suited in > include/linux/mfd but I don't think it matters too much. I guess it makes > sense to follow convention for the directory and treat it like the other > platform headers, maybe something like: > > soc: qcom: spmi-pmic: convert hex numbers to lowercase Agree. -- DEPRECATED: Please use lee@xxxxxxxxxx
