RE: [PATCH v4 5/6] iommu: Use EINVAL for incompatible device/domain in ->attach_dev

Date Prev

Date Next

Thread Prev

Thread Next

Date Index

Thread Index

To: Nicolin Chen <nicolinc@xxxxxxxxxx>, "joro@xxxxxxxxxx" <joro@xxxxxxxxxx>, "suravee.suthikulpanit@xxxxxxx" <suravee.suthikulpanit@xxxxxxx>, "will@xxxxxxxxxx" <will@xxxxxxxxxx>, "robin.murphy@xxxxxxx" <robin.murphy@xxxxxxx>, "robdclark@xxxxxxxxx" <robdclark@xxxxxxxxx>, "dwmw2@xxxxxxxxxxxxx" <dwmw2@xxxxxxxxxxxxx>, "baolu.lu@xxxxxxxxxxxxxxx" <baolu.lu@xxxxxxxxxxxxxxx>, "agross@xxxxxxxxxx" <agross@xxxxxxxxxx>, "bjorn.andersson@xxxxxxxxxx" <bjorn.andersson@xxxxxxxxxx>, "matthias.bgg@xxxxxxxxx" <matthias.bgg@xxxxxxxxx>, "orsonzhai@xxxxxxxxx" <orsonzhai@xxxxxxxxx>, "baolin.wang@xxxxxxxxxxxxxxxxx" <baolin.wang@xxxxxxxxxxxxxxxxx>, "zhang.lyra@xxxxxxxxx" <zhang.lyra@xxxxxxxxx>, "jean-philippe@xxxxxxxxxx" <jean-philippe@xxxxxxxxxx>, "sricharan@xxxxxxxxxxxxxx" <sricharan@xxxxxxxxxxxxxx>

Subject: RE: [PATCH v4 5/6] iommu: Use EINVAL for incompatible device/domain in ->attach_dev

From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>

Date: Thu, 22 Sep 2022 08:19:30 +0000

Cc: "jgg@xxxxxxxxxx" <jgg@xxxxxxxxxx>, "konrad.dybcio@xxxxxxxxxxxxxx" <konrad.dybcio@xxxxxxxxxxxxxx>, "yong.wu@xxxxxxxxxxxx" <yong.wu@xxxxxxxxxxxx>, "thierry.reding@xxxxxxxxx" <thierry.reding@xxxxxxxxx>, "vdumpa@xxxxxxxxxx" <vdumpa@xxxxxxxxxx>, "jonathanh@xxxxxxxxxx" <jonathanh@xxxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "shameerali.kolothum.thodi@xxxxxxxxxx" <shameerali.kolothum.thodi@xxxxxxxxxx>, "christophe.jaillet@xxxxxxxxxx" <christophe.jaillet@xxxxxxxxxx>, "thunder.leizhen@xxxxxxxxxx" <thunder.leizhen@xxxxxxxxxx>, "quic_saipraka@xxxxxxxxxxx" <quic_saipraka@xxxxxxxxxxx>, "jon@xxxxxxxxxxxxx" <jon@xxxxxxxxxxxxx>, "yangyingliang@xxxxxxxxxx" <yangyingliang@xxxxxxxxxx>, "iommu@xxxxxxxxxxxxxxx" <iommu@xxxxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-arm-kernel@xxxxxxxxxxxxxxxxxxx" <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>, "linux-arm-msm@xxxxxxxxxxxxxxx" <linux-arm-msm@xxxxxxxxxxxxxxx>, "linux-mediatek@xxxxxxxxxxxxxxxxxxx" <linux-mediatek@xxxxxxxxxxxxxxxxxxx>, "linux-tegra@xxxxxxxxxxxxxxx" <linux-tegra@xxxxxxxxxxxxxxx>, "virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx" <virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx>

In-reply-to: <4469b88b4460fc230b8c394f806c134e627aa5bd.1663744983.git.nicolinc@nvidia.com>

References: <cover.1663744983.git.nicolinc@nvidia.com> <4469b88b4460fc230b8c394f806c134e627aa5bd.1663744983.git.nicolinc@nvidia.com>

> From: Nicolin Chen <nicolinc@xxxxxxxxxx>
> Sent: Wednesday, September 21, 2022 4:24 PM
> 
> Following the new rules in include/linux/iommu.h kdocs, update all drivers
> ->attach_dev callback functions to return EINVAL in the failure paths that
> are related to domain incompatibility.
> 
> Also, drop adjacent error prints to prevent a kernel log spam.
> 
> Signed-off-by: Nicolin Chen <nicolinc@xxxxxxxxxx>

Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>