Hi, On Thu, Sep 8, 2022, at 13:16, Krzysztof Kozlowski wrote: > On 07/09/2022 19:09, Sven Peter wrote: >> >> Bluetooth controllers share the common local-bd-address property. >> Add a generic YAML schema to replace bluetooth.txt for those. >> >> Signed-off-by: Sven Peter <sven@xxxxxxxxxxxxx> >> --- >> changes from v1: >> - removed blueetooth.txt instead of just replacing it with a >> deprecation note >> - replaced references to bluetooth.txt >> >> checkpatch complains here because it thinks I do to many things at once, >> I think it's better to replace bluetooth.txt in single commit though. >> Let me know if you prefer this to be split into multiple commits >> instead. >> >> .../bindings/net/bluetooth-controller.yaml | 30 +++++++++++++++++++ > > I propose to keep it in net/bluetooth subdirectory. In next patch you > can move there other files. Sure, I can also already move net/qualcomm-bluetooth.yaml to the new subdirectory since I need to touch it in this commit anyway. > >> .../devicetree/bindings/net/bluetooth.txt | 5 ---- >> .../bindings/net/qualcomm-bluetooth.yaml | 4 +-- >> .../bindings/soc/qcom/qcom,wcnss.yaml | 8 ++--- >> 4 files changed, 35 insertions(+), 12 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/net/bluetooth-controller.yaml >> delete mode 100644 Documentation/devicetree/bindings/net/bluetooth.txt >> >> diff --git a/Documentation/devicetree/bindings/net/bluetooth-controller.yaml b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml >> new file mode 100644 >> index 000000000000..0ea8a20e30f9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/bluetooth-controller.yaml >> @@ -0,0 +1,30 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/bluetooth-controller.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Bluetooth Controller Generic Binding >> + >> +maintainers: >> + - Marcel Holtmann <marcel@xxxxxxxxxxxx> >> + - Johan Hedberg <johan.hedberg@xxxxxxxxx> >> + - Luiz Augusto von Dentz <luiz.dentz@xxxxxxxxx> >> + >> +properties: >> + $nodename: >> + pattern: "^bluetooth(@.*)?$" >> + >> + local-bd-address: >> + $ref: /schemas/types.yaml#/definitions/uint8-array >> + minItems: 6 > > No need for minitems. Ok, dropped. Best, Sven
