On 14-09-22, 09:10, Bjorn Andersson wrote: > On Wed, Sep 14, 2022 at 04:51:39PM +0530, Vinod Koul wrote: > > From: David Dai <daidavid1@xxxxxxxxxxxxxx> > > David Collins wrote the downstream patch that this is based on, so this > should be David Collins <collinsd@xxxxxxxxxxxxxx> Thanks updated and posted v5 > > > > > PMIC v7 has different offset values and seqeunces, so add support for > > this new version of PMIC > > > > Signed-off-by: David Dai <daidavid1@xxxxxxxxxxxxxx> > > Ditto. > > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx> > > Tested-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> # SM8450 HDK > > The rest looks reasonable to me. > > Regards, > Bjorn -- ~Vinod