Hi Dmitry! Overall this looks very good, I suppose we follow up with adding PXO and CXO to the device tree(s). > Create a separate DT bindings for Global Clock Controller on MSM8660 > platform. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> (...) > +examples: > + # Example for GCC for MSM8974: I think that should be "for MSM8660" now? With that nitpick: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij