On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by > moving devm_request_irq() to the probe callback. For reference, here's an analysis of the underlying problem and a series of fixes that addresses this: https://lore.kernel.org/all/20220913085320.8577-1-johan+linaro@xxxxxxxxxx/ Note that moving the irq request to probe also fixes the immediate issue, but that can now be done as a follow-on cleanup (optimisation) instead. > Dmitry Baryshkov (3): > drm/msm/dp: fold disable_irq into devm_request_irq > drm/msm/dp: switch to using platform_get_irq() > drm/msm/dp: move dp_request_irq() call to dp_display_probe() > > drivers/gpu/drm/msm/dp/dp_display.c | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) Johan