On 12/09/2022 22:40, Bhupesh Sharma wrote:
Introduce CONFIG_QCOM_THERMAL to allow better control over selection of various Qualcomm Thermal drivers available inside qcom/ directory. This is a preparatory change to allow new drivers to be added inside qcom/ directory in a more structured fashion later-on. Cc: Bjorn Andersson <andersson@xxxxxxxxxx> Cc: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx> Cc: Amit Kucheria <amitk@xxxxxxxxxx> Cc: Thara Gopinath <thara.gopinath@xxxxxxxxx> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> --- - v1 can be viewed here: https://www.spinics.net/lists/kernel/msg4510793.html - Fixed review comments from Dmitry received in v1. drivers/thermal/Makefile | 2 +- drivers/thermal/qcom/Kconfig | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/Makefile b/drivers/thermal/Makefile index def8e1a0399c..2506c6c8ca83 100644 --- a/drivers/thermal/Makefile +++ b/drivers/thermal/Makefile @@ -52,7 +52,7 @@ obj-$(CONFIG_DA9062_THERMAL) += da9062-thermal.o obj-y += intel/ obj-$(CONFIG_TI_SOC_THERMAL) += ti-soc-thermal/ obj-y += st/ -obj-$(CONFIG_QCOM_TSENS) += qcom/ +obj-y += qcom/ obj-y += tegra/ obj-$(CONFIG_HISI_THERMAL) += hisi_thermal.o obj-$(CONFIG_MTK_THERMAL) += mtk_thermal.o diff --git a/drivers/thermal/qcom/Kconfig b/drivers/thermal/qcom/Kconfig index 2c7f3f9a26eb..ccfd090273c1 100644 --- a/drivers/thermal/qcom/Kconfig +++ b/drivers/thermal/qcom/Kconfig @@ -1,8 +1,17 @@ # SPDX-License-Identifier: GPL-2.0-only + +config QCOM_THERMAL + tristate "Thermal drivers on Qualcomm Snapdragon series of SoCs" + help + Support for thermal drivers on Qualcomm Snapdragon series of SoCs. + There are several thermal sensors available on the Qualcomm Socs + which can be used for thermal mitigation purposes. + config QCOM_TSENS tristate "Qualcomm TSENS Temperature Alarm" depends on NVMEM_QCOM_QFPROM depends on ARCH_QCOM || COMPILE_TEST + select QCOM_THERMAL
What's the point of QCOM_THERMAL if other drivers are `select'ing it? I'd have understood if it would be a menuconfig guarding all Qualcomm thermal drivers.
help This enables the thermal sysfs driver for the TSENS device. It shows up in Sysfs as a thermal zone with multiple trip points. Disabling the @@ -15,6 +24,7 @@ config QCOM_SPMI_ADC_TM5 depends on OF && SPMI && IIO select REGMAP_SPMI select QCOM_VADC_COMMON + select QCOM_THERMAL help This enables the thermal driver for the ADC thermal monitoring device. It shows up as a thermal zone with multiple trip points. @@ -25,6 +35,7 @@ config QCOM_SPMI_TEMP_ALARM tristate "Qualcomm SPMI PMIC Temperature Alarm" depends on OF && SPMI && IIO select REGMAP_SPMI + select QCOM_THERMAL help This enables a thermal sysfs driver for Qualcomm plug-and-play (QPNP) PMIC devices. It shows up in sysfs as a thermal sensor with multiple @@ -35,6 +46,7 @@ config QCOM_SPMI_TEMP_ALARM config QCOM_LMH tristate "Qualcomm Limits Management Hardware" depends on ARCH_QCOM && QCOM_SCM + select QCOM_THERMAL help This enables initialization of Qualcomm limits management hardware(LMh). LMh allows for hardware-enforced mitigation for cpus based on
-- With best wishes Dmitry
