On 09/09/2022 16:30, Krzysztof Kozlowski wrote:
On 09/09/2022 15:20, Dmitry Baryshkov wrote:
Add pxo clock to the 8960 bindings (used by the HDMI PLL)
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
---
.../bindings/phy/qcom,hdmi-phy-other.yaml | 23 ++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml
index fdb277edebeb..2c21e120ff8d 100644
--- a/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,hdmi-phy-other.yaml
@@ -53,7 +53,6 @@ allOf:
contains:
enum:
- qcom,hdmi-phy-8660
- - qcom,hdmi-phy-8960
then:
properties:
clocks:
@@ -63,6 +62,24 @@ allOf:
- const: slave_iface
vddio-supply: false
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,hdmi-phy-8960
+ then:
+ properties:
+ clocks:
+ minItems: 1
+ maxItems: 2
+ clock-names:
+ minItems: 1
+ items:
+ - const: slave_iface
+ - const: pxo
Why pxo is optional? Commit msg does not say much here.
It's optional as it is not present in current DT files. The driver will
fallback to 'pxo_board' if the clock is not present.
It seems you also miss the DTS change adding the clock.
Oh, I'll add it to v2.
--
With best wishes
Dmitry
