On 09/09/2022 01:12, Richard Acayan wrote: > The Snapdragon 670 adds and removes some clocks, adds new frequencies, and > adds a new GPLL (Global Phase-Locked Loop) in reference to SDM845, while > also removing some GDSCs. Despite these differences, there are many > similarities with SDM670. Add data for SDM670 in the driver for SDM845 to > reuse the most of the clock data. > > Advantages and disadvantages of this approach: > + maintenance applies to both sdm670 and sdm845 by default > + less duplicate code (clocks) means smaller distro/pre-built kernels > with all drivers enabled > - clocks for both SoC's must be compiled if the user wants clocks for one > specific SoC (both or none) > - additional testing needed for sdm845 devices > > Link: https://android.googlesource.com/kernel/msm/+/443bd8d6e2cf54698234c752e6de97b4b8a528bd%5E%21/#F10 > Signed-off-by: Richard Acayan <mailingradian@xxxxxxxxx> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
