On 07/09/2022 19:57, Rob Herring wrote: > On Wed, Sep 07, 2022 at 12:15:51PM +0200, Krzysztof Kozlowski wrote: >> Convert Qualcomm Audio Stream Manager (Q6ASM) bindings to DT schema. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> --- >> >> Expected warning because the qcom,apr.yaml is being fixed in next commit: >> >> Documentation/devicetree/bindings/sound/qcom,q6asm.example.dtb: apr: service@7: 'dais' does not match any of the regexes: '^.*@[0-9a-f]+$', 'pinctrl-[0-9]+' >> From schema: /home/krzk/dev/linux/linux/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml >> >> Changes since v1: >> 1. New patch. >> --- >> .../devicetree/bindings/sound/qcom,q6asm.txt | 70 ----------- >> .../devicetree/bindings/sound/qcom,q6asm.yaml | 112 ++++++++++++++++++ >> 2 files changed, 112 insertions(+), 70 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.txt >> create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.yaml > > Should be qcom,q6asm-dais.yaml or you need to add qcom,q6asm compatible? Right, it should be -dais. > >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6asm.txt b/Documentation/devicetree/bindings/sound/qcom,q6asm.txt >> deleted file mode 100644 >> index 0d0075125243..000000000000 >> --- a/Documentation/devicetree/bindings/sound/qcom,q6asm.txt >> +++ /dev/null >> @@ -1,70 +0,0 @@ >> -Qualcomm Audio Stream Manager (Q6ASM) binding >> - >> -Q6ASM is one of the APR audio service on Q6DSP. >> -Please refer to qcom,apr.txt for details of the common apr service bindings >> -used by the apr service device. >> - >> -- but must contain the following property: >> - >> -- compatible: >> - Usage: required >> - Value type: <stringlist> >> - Definition: must be "qcom,q6asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>". >> - Or "qcom,q6asm" where the version number can be queried >> - from DSP. >> - example "qcom,q6asm-v2.0" > > Where is this compatible handled now? The "qcom,q6asm" is handled in: Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml The "qcom,q6asm-v<MAJOR-NUMBER>.<MINOR-NUMBER>" is not handled because it seems it is not used anywhere. I did not find such usage also in downstream sources, so it seems version can be always auto-detected (I did not confirm it with datasheet, though). I'll explain this in commit msg. Best regards, Krzysztof
