Bindings expect PMIC GPIO pin configuration nodes to be named with '-state' suffix: qcom/msm8996-xiaomi-scorpio.dtb: pmic@0: gpio@c000: 'irled-default', 'keypad-default' do not match any of the regexes: '-state$', 'pinctrl-[0-9]+' Drop also additional indentation via "pinconf" to make the code a bit smaller. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> --- .../boot/dts/qcom/msm8996-xiaomi-common.dtsi | 16 +++++++--------- .../boot/dts/qcom/msm8996-xiaomi-scorpio.dts | 16 +++++++--------- 2 files changed, 14 insertions(+), 18 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi index 6d6e0fb4d270..78a1977d0593 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-common.dtsi @@ -651,15 +651,13 @@ vdd_gfx: s2 { }; &pm8994_gpios { - irled_default: irled-default { - pinconf { - pins = "gpio5"; - function = PMIC_GPIO_FUNC_FUNC1; - output-low; - qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>; - power-source = <PM8994_GPIO_S4>; - bias-disable; - }; + irled_default: irled-default-state { + pins = "gpio5"; + function = PMIC_GPIO_FUNC_FUNC1; + output-low; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_HIGH>; + power-source = <PM8994_GPIO_S4>; + bias-disable; }; wlan_en_default: wlan-en-state { diff --git a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts index d287fa77e45a..895050831267 100644 --- a/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts +++ b/arch/arm64/boot/dts/qcom/msm8996-xiaomi-scorpio.dts @@ -278,15 +278,13 @@ &pm8994_gpios { "UIM_BATT_ALARM", /* GPIO_21 */ "NC"; /* GPIO_22 */ - keypad_default: keypad-default { - pinconf { - pins = "gpio7", "gpio10"; - function = PMIC_GPIO_FUNC_FUNC1; - output-low; - qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>; - power-source = <PM8994_GPIO_S4>; - bias-disable; - }; + keypad_default: keypad-default-state { + pins = "gpio7", "gpio10"; + function = PMIC_GPIO_FUNC_FUNC1; + output-low; + qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>; + power-source = <PM8994_GPIO_S4>; + bias-disable; }; }; -- 2.34.1