On Mon, Sep 05, 2022 at 06:53:23PM +0200, Krzysztof Kozlowski wrote: > On 05/09/2022 18:45, Krzysztof Kozlowski wrote: > > On 02/09/2022 20:51, Andrew Halaney wrote: > >> Right now, running make dt_binding_check results in this snippet: > >> > >> /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: 'additionalProperties' is a required property > >> hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties" > >> from schema $id: http://devicetree.org/meta-schemas/base.yaml# > >> SCHEMA Documentation/devicetree/bindings/processed-schema.json > >> <snip..> > >> /mnt/extrassd/git/linux-next/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml: ignoring, error in schema: > >> > >> Which results in the schema not being properly evaluated. Swap out > >> unevaluatedProperties which doesn't seem to be doing anything for > >> additionalProperties. > > > > unevaluatedProperties were required due to usage of defs-allOf > > (ba5d99609a5e ("regulator: dt-bindings: qcom,rpmh: document supplies per > > variant") > > ). > > > > Are you sure that it works correctly with additionalProperties? > > > > Judging by errors it doesn't.... > > What's more - I cannot reproduce that error (latest released dtschema)... > Ugh, I thought maybe I had ran into something here that was only in linux-next, but no. I've had my environment borked the whole time I was working on this series. So sorry about that. I'll send a v2 once I rework things with my environment working properly. Your comments here make sense to me -- unevaluatedProperties makes sense here based on what I see in the example binding... so this patch and the next will get dropped entirely. Thanks, Andrew
