On 9/6/22 11:33, Krzysztof Kozlowski wrote: > On 03/09/2022 19:41, Iskren Chernev wrote: >> Add initial support for OnePlus Nord N100, based on SM4250. Currently >> working: >> - boots >> - usb >> - buildin flash storage (UFS) >> - SD card reader >> >> Signed-off-by: Iskren Chernev <iskren.chernev@xxxxxxxxx> >> --- >> Remaining issues from make dtbs_check: >> - rpm-requests: it doesn't like the pm6125-regulators subnode. Every other >> DTS I checked is written in this way. > > Yes, I sent patches for it, already merged, so please rebase on linux-next. > > https://lore.kernel.org/all/20220828084341.112146-1-krzysztof.kozlowski@xxxxxxxxxx/ Great, thanks! >> + >> + clocks { >> + xo-board { > > These should be overridden by label, not full node path. Will do. >> +&rpm_requests { >> + pm6125-regulators { > > Please rebase and test with > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml I will, I'm just waiting for Konrad to say what to do about the reserved-memory nodes. For some reason mainline doesn't use alloc-ranges (dynamic) regions. On the other hand all of the dynamic ranges are not used ATM, so I can just drop them? > Best regards, > Krzysztof