On 22/08/2022 20:58, Dmitry Baryshkov wrote: > On 06/07/2022 18:52, Krzysztof Kozlowski wrote: >> On 06/07/2022 16:52, Dmitry Baryshkov wrote: >>> Make display/msm/gmu.yaml describe all existing GMU variants rather than >>> just the 630.2 (SDM845) version of it. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> >>> --- >>> .../devicetree/bindings/display/msm/gmu.yaml | 166 +++++++++++++++--- >>> 1 file changed, 146 insertions(+), 20 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/gmu.yaml b/Documentation/devicetree/bindings/display/msm/gmu.yaml >>> index fe55611d2603..67fdeeabae0c 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/gmu.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/gmu.yaml >>> @@ -20,35 +20,24 @@ description: | >>> properties: >>> compatible: >>> items: >>> - - enum: >>> - - qcom,adreno-gmu-630.2 >>> + - pattern: '^qcom,adreno-gmu-6[0-9][0-9]\.[0-9]$' >>> - const: qcom,adreno-gmu >>> >>> reg: >>> - items: >>> - - description: Core GMU registers >>> - - description: GMU PDC registers >>> - - description: GMU PDC sequence registers >>> + minItems: 3 >>> + maxItems: 4 >>> >>> reg-names: >>> - items: >>> - - const: gmu >>> - - const: gmu_pdc >>> - - const: gmu_pdc_seq >>> + minItems: 3 >>> + maxItems: 4 >>> >>> clocks: >>> - items: >>> - - description: GMU clock >>> - - description: GPU CX clock >>> - - description: GPU AXI clock >>> - - description: GPU MEMNOC clock >>> + minItems: 4 >>> + maxItems: 7 >>> >>> clock-names: >>> - items: >>> - - const: gmu >>> - - const: cxo >>> - - const: axi >>> - - const: memnoc >>> + minItems: 4 >>> + maxItems: 7 >>> >>> interrupts: >>> items: >>> @@ -76,6 +65,9 @@ properties: >>> >>> operating-points-v2: true >>> >>> + opp-table: >>> + type: object >> >> instead: opp-table:true > > Wouldn't this allow e.g. using just 'opp-table;' as a flag? You're right and Rob also corrected me. Your original patch was correct (type:object). Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
