On 17/08/2022 23:57, Konrad Dybcio wrote: > > > On 17.08.2022 15:03, Krzysztof Kozlowski wrote: >> The TCSR halt regs are next to TCSR mutex, so before converting the TCSR >> mutex into device with address space, we need to split the halt regs to >> its own syscon device. This also describes more accurately the devices >> and their IO address space. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> --- > Not tested on a device, but looks good to the eye: > Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> > > On a note, are they really named TCSR_1 and TCSR_2 in the docs? > Qualcomm is usually more exquisite in their naming :P This is not entirely separate address space, therefore it does not have a separate name. The address space name is still TCSR_MUTEX which consists of actual MUTEX regs, halt regs and bunch of others. The second one 0x7a0000 (where label I renamed to tcsr_2) is called TCSR_REGS. This applies to other patches as well, so maybe you prefer to have labels matching the spec? The first would be tcsr_mutex_regs, although it is not entirely correct, because it does not include now the TCSR mutex regs... Best regards, Krzysztof
